Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quash ruby 3.4 warnings #47

Merged
merged 2 commits into from
Apr 8, 2024
Merged

quash ruby 3.4 warnings #47

merged 2 commits into from
Apr 8, 2024

Conversation

flavorjones
Copy link
Member

  • add frozen-string-literal: true to some lib files
    • and explicitly make some strings mutable
  • add frozen-string-literal: false to some test files
  • add parenthesis in one test that was generating a warning

@flavorjones
test: update uri tests with better names
cffe324 
so we can clearly tell which entry fails
@flavorjones flavorjones requested a review from knu as a code owner March 24, 2024 13:17
@flavorjones flavorjones mentioned this pull request Mar 24, 2024
Closed
@flavorjones flavorjones force-pushed the flavorjones-ruby-3.4-warnings branch from d0676f4 to 22ea7af Compare March 24, 2024 14:03
@flavorjones
Copy link
Member Author

@knu Can you please review this when you get a chance?

knu
knu approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@knu knu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍✨

@flavorjones flavorjones merged commit 6b2ffb6 into master Apr 8, 2024
7 checks passed
@flavorjones flavorjones deleted the flavorjones-ruby-3.4-warnings branch April 9, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knu knu knu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flavorjones @knu