fix:resolved sign-up distortion[#2133] #86
Conversation
|
👋 Hey, the Quality Gate has PASSED. ✅Status: OK, ✅Status: OK, ✅Status: OK, ✅Status: OK, |
SonarQube Quality Gate Result
updated: 12/23/2024, 08:57:20 (UTC+0) |
|
👋 Hey, the Quality Gate has PASSED. ✅Status: OK, ✅Status: OK, ✅Status: OK, ✅Status: OK, |
| <div class="d-flex flex-column mx-auto sparrow-fs-14 sparrow-fs-300"> | ||
| <p> | ||
| Check your inbox for the verification code sent to <span | ||
| class="sparrow-fw-700 text-whiteColor cursor-pointer">{emailText}</span | ||
| Check your inbox for the verification code sent to<span | ||
| class="sparrow-fw-700 text-whiteColor cursor-pointer email-text d-inline-block">{emailText}</span | ||
| > and enter it below to proceed. | ||
| </p> |
There was a problem hiding this comment.
Could you add a limit to crop the text and display an ellipsis (...) when it overflows?
https://github.com/sparrowapp-dev/sparrow-app-auth/pull/79/files
please refer to this pull request
There was a problem hiding this comment.
@itsmdasifraza I will fix it.
|
Could you change the base branch to development |
There was a problem hiding this comment.
@aakashreddy-p whenever you raise PR, raise it in development not in main.
|
👋 Hey, the Quality Gate has FAILED. |
|
👋 Hey, the Quality Gate has FAILED. |
| let isRegistered = false; | ||
| let maxlength = 40; | ||
| let redirectRules = { |
There was a problem hiding this comment.
use
const MAX_LENGTH = 100;
| // This function will reduce the email size if it is too long. | ||
| function handleEmail(text:string,maxlength:number){ | ||
| if(text.length > maxlength){ | ||
| return text.slice(0, maxlength) + "..." | ||
| } |
There was a problem hiding this comment.
use arrow function here, return type is missing
| } | ||
| $: EmailText = handleEmail(emailText, maxlength); |
There was a problem hiding this comment.
variable name should be camel case.
|
👋 Hey, the Quality Gate has FAILED. |
Updated the CSS properties so that it can take large emails[#2133].