Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Added Magic Code Flow verify section #87

Merged
merged 8 commits into from
Dec 16, 2024

Conversation

Abhishek9503
Copy link
Contributor

In this PR i have added the magic code flow verify section , integrated the api for send magic code and verify magic code.

@Abhishek9503 Abhishek9503 self-assigned this Dec 13, 2024
Copy link

👋 Hey, the Quality Gate has FAILED.
💣Status: ERROR,
MetricKey: new_coverage
Comparator: LT
ErrorThreshold: 80
ActualValue: 0.0

Copy link

SonarQube Quality Gate Result

Metric Status Value Error Threshold
New reliability rating ✅ OK 1 > 1
New security rating ✅ OK 1 > 1
New maintainability rating ✅ OK 1 > 1
New coverage ❗ Error 0 < 80
New duplicated lines density ✅ OK 0 > 3

View on SonarQube

updated: 12/13/2024, 12:44:50 (UTC+0)

@Abhishek9503 Abhishek9503 marked this pull request as draft December 14, 2024 08:13
@Astitva877 Astitva877 changed the base branch from main to revamp-login-flow December 16, 2024 05:45
@Abhishek9503 Abhishek9503 marked this pull request as ready for review December 16, 2024 10:33
};

const verifyMagicCode = async (verifyInfo: MagicCodeVerifyBody) => {
console.log("This is verify code credentialss",verifyInfo)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove console.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@Astitva877 Astitva877 merged commit f74ddc5 into revamp-login-flow Dec 16, 2024
@Astitva877 Astitva877 deleted the feat/added-magic-code-flow branch December 16, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants