Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added animations in checkbox[123] #1125

Merged
merged 6 commits into from
Jun 26, 2024
Merged

fix: added animations in checkbox[123] #1125

merged 6 commits into from
Jun 26, 2024

Conversation

isha-dubey
Copy link
Contributor

@isha-dubey isha-dubey commented Jun 24, 2024 •
edited by itsmdasifraza
Loading

Description

#1047

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build

Have you tested locally?

  • 👍 yes
  • 🙅 no, because I am lazy

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md

Any Known issue?

Related Story, task & Documents?

@isha-dubey isha-dubey self-assigned this Jun 24, 2024
@isha-dubey isha-dubey requested a review from gc-codes as a code owner June 24, 2024 07:29
isha-dubey
isha-dubey commented Jun 25, 2024
View reviewed changes
src/packages/@library/ui/button/Button.svelte
Comment on lines +151 to +153
.custom-btn-teritiary:hover{
color: var(--white-color);
background-color: var(--bg-primary-300 );
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay looking into it.

@itsmdasifraza itsmdasifraza merged commit 07625eb into sparrowapp-dev:development Jun 26, 2024
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Astitva877 Astitva877 Astitva877 left review comments

@itsmdasifraza itsmdasifraza itsmdasifraza approved these changes

@gc-codes gc-codes Awaiting requested review from gc-codes gc-codes is a code owner

Assignees

@isha-dubey isha-dubey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isha-dubey @itsmdasifraza @Astitva877