Refactor/collection list #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please attach the issue link |
Astitva877
reviewed
Apr 19, 2024
src/lib/components/collections/collections-list/import-curl/ImportCurl.viewModel.ts
Outdated
Show resolved
Hide resolved
Astitva877
reviewed
Apr 19, 2024
src/lib/components/collections/collections-list/searchTree/Request.svelte
Outdated
Show resolved
Hide resolved
Astitva877
requested changes
Apr 19, 2024
There was a problem hiding this comment.
@theketan26 comments are missing from various places, we can add comments for functions, imports to make the code more understandable.
|
Please attach the issue link |
itsmdasifraza
approved these changes
Apr 26, 2024
Astitva877
approved these changes
Apr 29, 2024
gc-codes
merged commit 8022270
into
sparrowapp-dev:feat/sparrow-refactoring
1 of 3 checks passed
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor: Collection list
Issue #738
What type of PR is this? (check all applicable)
Have you tested locally?
Added tests?
Added to documentation?
Any Known issue?
Related Story, task & Documents?