feat: Added shortcut button [123] #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please attach the issue link |
1 similar comment
|
Please attach the issue link |
itsmdasifraza
requested changes
May 24, 2024
Comment on lines
1
to
3
| <svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
| <g clip-path="url(#clip0_3439_4638)"> | ||
| <path d="M13.3327 11.3333C13.3327 12.0687 12.7348 12.6667 11.9993 12.6667H3.99935C3.26393 12.6667 2.66602 12.0687 2.66602 11.3333V4.66666C2.66602 3.93124 3.26393 3.33333 3.99935 3.33333H6.66602C7.08477 3.33333 7.4806 3.53124 7.73268 3.86666L8.13268 4.39999C8.25768 4.56874 8.4556 4.66666 8.66602 4.66666H11.9993C12.7348 4.66666 13.3327 5.26458 13.3327 5.99999V11.3333ZM7.49935 10.5C7.49935 10.7771 7.72227 11 7.99935 11C8.27643 11 8.49935 10.7771 8.49935 10.5V9.16666H9.83268C10.1098 9.16666 10.3327 8.94375 10.3327 8.66666C10.3327 8.38958 10.1098 8.16666 9.83268 8.16666H8.49935V6.83333C8.49935 6.55625 8.27643 6.33333 7.99935 6.33333C7.72227 6.33333 7.49935 6.55625 7.49935 6.83333V8.16666H6.16602C5.88893 8.16666 5.66602 8.38958 5.66602 8.66666C5.66602 8.94375 5.88893 9.16666 6.16602 9.16666H7.49935V10.5Z" fill="#8A9299"/> |
There was a problem hiding this comment.
<script>
export let height = "24px";
export let width = "24px";
export let color = "grey";
</script>
add this script, and pass value as a props
Comment on lines
554
to
557
| > | ||
| <RequestIcon height="16px" width="16px" /> | ||
| </div> | ||
| </div> |
Comment on lines
540
to
542
| > | ||
| <FolderPlusIcon /> | ||
| </div> |
There was a problem hiding this comment.
pass height, width ,color prop here
Comment on lines
724
to
731
| margin-left: 24px; | ||
| } | ||
| .folderIcon:hover{ | ||
| background: var(--right-border); | ||
| } | ||
| .requestIcon:hover{ | ||
| background: var(--right-border); | ||
| } |
There was a problem hiding this comment.
use common class for both
|
Please attach the issue link |
…parrowapp-dev/sparrow-app into feat/added-shortcut- [123]
|
Please attach the issue link |
itsmdasifraza
approved these changes
May 27, 2024
itsmdasifraza
merged commit 7b3dd88
into
sparrowapp-dev:feat/sparrow-refactoring
1 of 3 checks passed
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added shortcut button in the collection page
What type of PR is this? (check all applicable)
Have you tested locally?
Added tests?
Added to documentation?
Any Known issue?
Related Story, task & Documents?