Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging] fix: Fixed folder rename and collection rename function #929

Conversation

Abhishek9503
Copy link
Contributor

@Abhishek9503 Abhishek9503 commented May 31, 2024

Description

In this PR i have changed two functions that is folder renaming and collection renaming function which was previously called without renaming the folder and collection name so added condition that function will only called when the folder or collection is renamed also i have fixed the collection name input Ui which is not aligned with button.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build

Have you tested locally?

  • 👍 yes
  • 🙅 no, because I am lazy

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md

Any Known issue?

Related Story, task & Documents?

@Abhishek9503 Abhishek9503 self-assigned this May 31, 2024
@Abhishek9503 Abhishek9503 requested a review from gc-codes as a code owner May 31, 2024 13:32
@punitkashyup
Copy link
Member

Please attach the issue link

1 similar comment
@punitkashyup
Copy link
Member

Please attach the issue link

@itsmdasifraza itsmdasifraza merged commit 4b4a555 into sparrowapp-dev:staging Jun 3, 2024
0 of 3 checks passed
@punitkashyup
Copy link
Member

Please attach the issue link

@pratikshinde590
Copy link
Contributor

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants