Skip path logic when not needed

This makes things a bit quicker when dealing with lots of files
spatie · Jul 27, 2024 · 914d490 · 914d490
1 parent 65e10ad
commit 914d490
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/Conversions/FileManipulator.php b/src/Conversions/FileManipulator.php
@@ -59,13 +59,17 @@ public function performConversions(
 
         $conversions
             ->reject(function (Conversion $conversion) use ($onlyMissing, $media) {
+                if (! $onlyMissing) {
+                    return false;
+                }
+
                 $relativePath = $media->getPath($conversion->getName());
 
                 if ($rootPath = config("filesystems.disks.{$media->disk}.root")) {
                     $relativePath = str_replace($rootPath, '', $relativePath);
                 }
 
-                return $onlyMissing && Storage::disk($media->disk)->exists($relativePath);
+                return Storage::disk($media->disk)->exists($relativePath);
             })
             ->each(function (Conversion $conversion) use ($media, $copiedOriginalFile) {
                 (new PerformConversionAction)->execute($conversion, $media, $copiedOriginalFile);