Updated doc block for $media->model_id #3369
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change made in https://github.com/spatie/laravel-medialibrary/pull/3341/files#diff-8adff69d13774eb09fba1b9b993d0be0d466cf8d43523c9d8050884207cd5901R38 breaks our Larastan checks.
We use strict comparison checks between the
$media->model_id
and an integer (eg:$media->model_id === $model->id
) and since the doc block in the above PR says it's astring
only, it breaks. But that column can of course also be an integer, so I guess that this was just missed in the PR.This PR updates the doc block to be
@property string|int
instead.