Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating temporary directory until needed #3376

Closed
wants to merge 2 commits into from

Conversation

cosmastech
Copy link
Contributor

@cosmastech cosmastech commented Sep 15, 2023

In performing conversions, a temporary directory is created and then the original file is copied to the temp directory. It's possible that this is never needed (since there may be no new conversions to create). I've created a simple wrapper that handles creating the temporary directory and copying the file only when first requested.

Not sure about tests here. Let me know if you have any ideas on what you would like to see on that front.

@cosmastech cosmastech marked this pull request as draft September 15, 2023 14:19
@cosmastech cosmastech marked this pull request as ready for review September 16, 2023 11:28
@freekmurze
Copy link
Member

Thank you! I'm going to pass on this for now to keep the package as simple as it can be.

@freekmurze freekmurze closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants