Avoid creating temporary directory until needed #3376
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In performing conversions, a temporary directory is created and then the original file is copied to the temp directory. It's possible that this is never needed (since there may be no new conversions to create). I've created a simple wrapper that handles creating the temporary directory and copying the file only when first requested.
Not sure about tests here. Let me know if you have any ideas on what you would like to see on that front.