Remove unnecessary directory creation #3397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests to remove the conditional directory creation logic in the
getMediaLibrary()
function.Unless it's a very specific reason to do it, I think it would be better to avoid checking for a specific driver to run the logic for creating a directory or not (since that can cause unexpected issues).
In our case we ran into an issue with the solution since another library was masking the real driver name (so it wasn't called anything with "s3" anymore), and since our S3 permission setup only allowed writing files, not creating an empty directory, the storing of the file caused an exception to be thrown.
See relevant comment at https://github.com/spatie/laravel-medialibrary/pull/3389/files#r1338270714.
According to Flysystem, the actual driver creates the required directory when attempting to write a file;