Assumptions for work depth analysis #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Philipp Schaad <schaad.phil@gmail.com>
Co-authored-by: Philipp Schaad <schaad.phil@gmail.com>
phschaad
requested changes
Sep 18, 2023
src/components/dace_interface.ts
Outdated
| this.genericErrorHandler(error.message, error.details); | ||
| reject(error.message); | ||
|
|
||
| vscode.window.showInputBox({ |
There was a problem hiding this comment.
This is quite some code repetition, is it possible to factor this out into a separate small function? (Showing the prompt, checking for the format, showing error message if violated, etc.)
backend/run_dace.py
Outdated
| @@ -53,7 +53,7 @@ | |||
|
|
|||
| sys.path.append(path.abspath(path.dirname(__file__))) | |||
|
|
|||
| from dace_vscode import arith_ops, depth, transformations | |||
| from dace_vscode import depth, transformations | |||
There was a problem hiding this comment.
Can't the dace_vscode.arith_ops module be removed entirely now?
|
|
||
| from dace_vscode.utils import ( | ||
| load_sdfg_from_json, | ||
| get_exception_message, | ||
| ) | ||
|
|
||
| def get_work(sdfg_json, assumptions): |
There was a problem hiding this comment.
This module should now probably be renamed to work_depth or something :-)
|
I integrated all your comments:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the user to enter assumptions for the symbols before calling the work depth analysis.
It uses a VS code
InputBoxto handle the input. Validity of the input is checked by a regex. If the check passes, the assumptions are forwarded to the work depth analysis.The corresponding PR to the dace repo can be found here.