Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passes Interface Improvements #1124

Merged
merged 14 commits into from
Oct 24, 2022
Merged

Passes Interface Improvements #1124

merged 14 commits into from
Oct 24, 2022

Conversation

phschaad
Copy link
Collaborator

@phschaad phschaad commented Oct 18, 2022 •
edited
Loading

  • Provide an interface to query all available passes
  • Group passes and pipelines into categories
  • Remove deprecated functions and transformations that were surpassed by passes
  • Make passes and pipelines use properties rather than (just) dataclasses
  • Rename the Pipeline map scope to PipelineScope to avoid namespace clashes with the new pass pipelines

This serves as a prerequisite for spcl/dace-vscode#203

@phschaad phschaad changed the title Provide an interface to obtain all available passes Passes Interface Oct 21, 2022
@phschaad phschaad changed the title Passes Interface Passes Interface Improvements Oct 21, 2022
@phschaad phschaad marked this pull request as ready for review October 21, 2022 11:22
@phschaad phschaad requested a review from tbennun October 21, 2022 11:22
tbennun
tbennun requested changes Oct 23, 2022
View reviewed changes
dace/transformation/pass_pipeline.py Outdated Show resolved Hide resolved
dace/transformation/pass_pipeline.py Outdated Show resolved Hide resolved
dace/transformation/pass_pipeline.py Show resolved Hide resolved
dace/transformation/passes/analysis.py Show resolved Hide resolved
dace/transformation/passes/constant_propagation.py Outdated Show resolved Hide resolved
dace/transformation/passes/fusion_inline.py Outdated Show resolved Hide resolved
dace/transformation/passes/fusion_inline.py Outdated Show resolved Hide resolved
dace/transformation/passes/util.py Outdated Show resolved Hide resolved
@phschaad phschaad requested a review from tbennun October 24, 2022 06:58
tbennun
tbennun approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass

@phschaad phschaad enabled auto-merge (squash) October 24, 2022 08:10
@phschaad phschaad merged commit 1302cf8 into master Oct 24, 2022
@phschaad phschaad deleted the available_passes branch March 1, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbennun tbennun tbennun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phschaad @tbennun