Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add offset normalization to Fortran frontend #1367

Merged
merged 24 commits into from
Sep 11, 2023
Merged

Add offset normalization to Fortran frontend #1367

merged 24 commits into from
Sep 11, 2023

Conversation

mcopik
Copy link
Contributor

@mcopik mcopik commented Sep 8, 2023

This PR contributes a Fortran AST pass to normalize all array offsets. In addition, it fixes a few additional problems:

  • Adds a pass to assign parent scope to each AST node.
  • Adds a pass accumulating all variable declarations in a given scope.
  • Fixes handling of Fortran array assignment when offsets are present.

@acalotoiu I'm going to do a few more tests covering more complex function invocations and 3D arrays. Please look when you can to verify this is the intended behavior.

mcopik and others added 22 commits August 14, 2023 18:38
@mcopik
Support in Fortran frontend arrays with offset declaration
2420440
@mcopik
Support shape attribute specification in the Fortran frontend
63b074b
@mcopik
Rename array attributes test
e1b4399
@mcopik
Remove old code
37fa580
@mcopik
Fix handling of non-dimensional attributes in Fortran frontend
b9e9f61
@acalotoiu
Merge branch 'master' into fortran_frontend_array_dimensions
5f212e7
@mcopik
Add Fortran AST transformation assigning to each node its parent scope
427f467
@mcopik
Add new Fortran parser function to export pure AST, not SDFG
0d19df2
@mcopik
Merge branch 'fortran_frontend_array_dimensions' into fortran_ast_par…
ab7930d 
…ents
@mcopik
Add Fortran AST pass to gather all variable declarations inside a scope
5cfbed3
@mcopik
First implementation of the offset normalization pass
2296556
@mcopik
Add Fortran AST transformation assigning to each node its parent scope
3f76982
@mcopik
Add new Fortran parser function to export pure AST, not SDFG
60e9547
@mcopik
Add Fortran AST pass to gather all variable declarations inside a scope
17eaf5a
@mcopik
First implementation of the offset normalization pass
1be4754
@mcopik
Merge branch 'fortran_ast_parents' of github.com:spcl/dace into fortr…
52f9d51 
…an_ast_parents
@mcopik
Remove dead and old code
027f1e2
@mcopik
Update the 2D offset normalizer tests to verify offsets on the AST level
b6d9320
@mcopik
Fix handling of ArrayToLoop when involved arrays have offsets
379dada
@mcopik
Add test verifying a 1D ArrayToLoop transform with offsets
c5ce575
@mcopik
Add test verifying that Fortran offset normalizer works for 1D and 2D…
2436051 
… arrays
@mcopik
Adjust offsets in Array2Loop only when it has offset different than d…
ec77693 
…efault's 1
@mcopik mcopik requested a review from acalotoiu September 8, 2023 18:13
@mcopik mcopik self-assigned this Sep 8, 2023
acalotoiu
acalotoiu requested changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@acalotoiu acalotoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parent of a node can also be a module no just a function, subroutine or program. The full complexity of Fortan in general is even broader, but modules we require support for directly.

@mcopik
Copy link
Contributor Author

mcopik commented Sep 8, 2023 •
edited
Loading

The parent of a node can also be a module no just a function, subroutine or program. The full complexity of Fortan in general is even broader, but modules we require support for directly.

@acalotoiu Fixed in commit 70c33dd, I also added a test verifying we catch the module as a parent node.

@acalotoiu acalotoiu self-requested a review September 11, 2023 18:40
acalotoiu
acalotoiu approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@acalotoiu acalotoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks!

@acalotoiu acalotoiu merged commit 680a956 into master Sep 11, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acalotoiu acalotoiu acalotoiu approved these changes

Assignees

@mcopik mcopik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcopik @acalotoiu