Highlighter now works on the whole line. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I said that too soon. Seems like there is some stylecop problem. Would you mind fixing snd I'll get this merged and a new version released asap. |
mkrueger
force-pushed
the
custom_highlighting
branch
from
2149ec5
to
b7b4034
Compare
|
fixed - missed that. I've another change I needed regarding to the completion where I ran into similar issues. |
|
Merged! Thank you for your contribution. Much appreciated! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know "no new features" so let's see that as a possible improvement for future versions.
The Highlighting interface works on tokens but for my use case I need context sensitive highlighting so it needs to work on the whole line and the highlighter to tokenize the line.
I moved the word highlighting to WordHighlighter so consuming code using that doesn't break.