Close immediate channel after writing to it to close wait group in merge logic #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillebaba
force-pushed
the
fix/immediate-channel
branch
from
2b76d6c to
aa98f85
Compare
t1mt
pushed a commit
to t1mt/spegel
that referenced
this pull request
Sep 3, 2024
Close immediate channel after writing to it to close wait group in merge logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that the merge channel will never close because the buffered channel will stay open. By closing the immediate channel we make sure that it completes immediately in the merge logic. This will leave the second channel as the only channel controlling when to close the merged channel.