fix(plugins/dates): add dmy option to fix #1131 #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great @hchiam, I think this also needs your suggested fix from https://github.com/spencermountain/compromise/pull/1129/files#r1690519347 |
|
amazing! |
i'll work on a quick pr to get this in hopefully before @spencermountain creates the next release |
hchiam
added a commit
to hchiam/compromise
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add dmy option to fix #1131
based on discussion in another PR: #1129 (comment)
for future reference for myself and maybe helpful for other devs, here's the path of references that led me to find the place i edited in the compromise-dates plugin code:
dates.js get() and others call parseDates > parse > parseRange > parseRanges > tryFull > parseDate > parse > explicit > parseExplicit > new Day() > Unit > spacetime (spacetime has a dmy option)
i saw spacetime used in other places and thought of adding
dmy: context.dmythere too, but i kept my changes minimal for my first try in this prexcluded the automatic changes to the package-lock version numbers