Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add direct tpm support for spire-agent #216

Merged
merged 50 commits into from
Feb 29, 2024
Merged

Add direct tpm support for spire-agent #216

merged 50 commits into from
Feb 29, 2024

Conversation

kfox1111
Copy link
Collaborator

No description provided.

@kfox1111
Add direct tpm support for spire-agent
fe16f5e 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111 kfox1111 marked this pull request as draft January 26, 2024 15:45
@kfox1111
Merge branch 'main' into direct-tpm-agent
938c736
@kfox1111
Add fingerprinting support
9557216 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Merge remote-tracking branch 'refs/remotes/origin/direct-tpm-agent' i…
6c3fce4 
…nto direct-tpm-agent

Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Add example
0c3c401 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111
Update charts/spire/charts/spire-agent/templates/configmap.yaml
b79bd1c 
Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov>
@kfox1111
Update charts/spire/charts/spire-agent/templates/configmap.yaml
ee3b021 
Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov>
@kfox1111
Merge branch 'main' into direct-tpm-agent
35ee210
@kfox1111
Fix broken tests
55c6f06 
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111 kfox1111 added the review ready Ready for review but not merge label Jan 29, 2024
@kfox1111
Fix hardcoded nodeAttestor and keyManager in spire-agent
0c6be12 
Fixes: #220

Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111 kfox1111 changed the base branch from main to spire-agent-config-fix January 30, 2024 14:39
Base automatically changed from spire-agent-config-fix to main January 30, 2024 19:33
@kfox1111
Merge branch 'main' into direct-tpm-agent
2e90089 
Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov>
@kfox1111
Pass the agent's securityContext on to Kubernetes
dea1673 
Currently its ignored.

Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111 kfox1111 changed the base branch from main to agent-sc-fix January 30, 2024 19:54
Base automatically changed from agent-sc-fix to main January 30, 2024 19:55
marcofranssen
marcofranssen reviewed Feb 18, 2024
View reviewed changes
Copy link
Collaborator

@marcofranssen marcofranssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small question and suggestion. Looks pretty neat.

examples/tpm-direct/values.yaml Show resolved Hide resolved
charts/spire/charts/spire-agent/values.yaml Show resolved Hide resolved
@kfox1111
Apply suggestions from code review
4f14281 
Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov>
@faisal-memon faisal-memon enabled auto-merge (squash) February 29, 2024 19:50
@faisal-memon faisal-memon merged commit a539065 into main Feb 29, 2024
28 checks passed
@faisal-memon faisal-memon deleted the direct-tpm-agent branch February 29, 2024 20:33
faisal-memon added a commit that referenced this pull request Mar 4, 2024
@faisal-memon
Bump spire Helm Chart version from 0.17.2 to 0.18.0
fd2f92e 
* 5849ea2 add pod labels to spire server values (#271)
* f512b06 Configurable daemonsets updateStrategy (#212)
* a539065 Add direct tpm support for spire-agent (#216)
* fcd0c11 Add direct tpm support for spire-server (#211)
* c570174 Enable CA settings via global (#268)
* ac83694 Initial SPIRE 1.9.0 support (#262)
* ddb4eff Bump test chart dependencies (#263)
* bfbafbc Fix OpenShift Federation Ingress bug (#260)
* a0baace Upgrade to spire-controller-manager 0.4.3 (#258)
* 1446f7e Add support for specifying agent authorized_delegates (#255)
* 0b6cd88 Add support for specifying server admin_ids (#254)
* 07a1c39 Add global override for kubectl tag (#251)
* b82a84d Bump test chart dependencies (#252)
* 7a1e731 Bump test chart dependencies (#246)
* a706063 make audit_log_enabled configurable (#241)
* 34a39cb Added emptyDir volume to spire-agent SCC (#243)
* a2e5a4e Add support for enabling the spire-agent admin socket (#234)
* febdcbf Fix whitespace in spire-agent daemonset

Signed-off-by: Faisal Memon <fymemon@yahoo.com>
faisal-memon added a commit that referenced this pull request Mar 4, 2024
@faisal-memon
Bump spire Helm Chart version from 0.17.2 to 0.18.0
260501b 
* beda725 Add pod labels to the SPIRE agent (#273)
* 077f152 Bump test chart dependencies (#272)
* 5849ea2 add pod labels to spire server values (#271)
* f512b06 Configurable daemonsets updateStrategy (#212)
* a539065 Add direct tpm support for spire-agent (#216)
* fcd0c11 Add direct tpm support for spire-server (#211)
* c570174 Enable CA settings via global (#268)
* ac83694 Initial SPIRE 1.9.0 support (#262)
* ddb4eff Bump test chart dependencies (#263)
* bfbafbc Fix OpenShift Federation Ingress bug (#260)
* a0baace Upgrade to spire-controller-manager 0.4.3 (#258)
* 1446f7e Add support for specifying agent authorized_delegates (#255)
* 0b6cd88 Add support for specifying server admin_ids (#254)
* 07a1c39 Add global override for kubectl tag (#251)
* b82a84d Bump test chart dependencies (#252)
* 7a1e731 Bump test chart dependencies (#246)
* a706063 make audit_log_enabled configurable (#241)
* 34a39cb Added emptyDir volume to spire-agent SCC (#243)
* a2e5a4e Add support for enabling the spire-agent admin socket (#234)
* febdcbf Fix whitespace in spire-agent daemonset

Signed-off-by: Faisal Memon <fymemon@yahoo.com>
@faisal-memon faisal-memon mentioned this pull request Mar 4, 2024
Merged
faisal-memon added a commit that referenced this pull request Mar 4, 2024
@faisal-memon
Bump spire Helm Chart version from 0.17.2 to 0.18.0 (#274)
cf2e213 
* beda725 Add pod labels to the SPIRE agent (#273)
* 077f152 Bump test chart dependencies (#272)
* 5849ea2 add pod labels to spire server values (#271)
* f512b06 Configurable daemonsets updateStrategy (#212)
* a539065 Add direct tpm support for spire-agent (#216)
* fcd0c11 Add direct tpm support for spire-server (#211)
* c570174 Enable CA settings via global (#268)
* ac83694 Initial SPIRE 1.9.0 support (#262)
* ddb4eff Bump test chart dependencies (#263)
* bfbafbc Fix OpenShift Federation Ingress bug (#260)
* a0baace Upgrade to spire-controller-manager 0.4.3 (#258)
* 1446f7e Add support for specifying agent authorized_delegates (#255)
* 0b6cd88 Add support for specifying server admin_ids (#254)
* 07a1c39 Add global override for kubectl tag (#251)
* b82a84d Bump test chart dependencies (#252)
* 7a1e731 Bump test chart dependencies (#246)
* a706063 make audit_log_enabled configurable (#241)
* 34a39cb Added emptyDir volume to spire-agent SCC (#243)
* a2e5a4e Add support for enabling the spire-agent admin socket (#234)
* febdcbf Fix whitespace in spire-agent daemonset

Signed-off-by: Faisal Memon <fymemon@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faisal-memon faisal-memon faisal-memon approved these changes

@marcofranssen marcofranssen marcofranssen left review comments

@dfeldman dfeldman Awaiting requested review from dfeldman

@mrsabath mrsabath Awaiting requested review from mrsabath mrsabath is a code owner

Assignees

@faisal-memon faisal-memon

Labels
None yet
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kfox1111 @marcofranssen @faisal-memon