-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to SPIRE 1.10.0 #393
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the options that were removed in 1.10, and update. Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
kfox1111
requested review from
marcofranssen,
faisal-memon,
mrsabath and
edwbuck
as code owners
July 9, 2024 15:13
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
mrsabath
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @kfox1111 for your updates
Ok. I think this has to do with the spiffe-oidc-discovery-provider running as non root now as of 1.10.0.
|
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
@kfox1111 is this ready to merge? |
Yeah. was waiting on your review |
faisal-memon
approved these changes
Jul 24, 2024
faisal-memon
added a commit
that referenced
this pull request
Aug 6, 2024
* 82a6d5d Should be `admin_socket_path` not `admin_socket_dir` (#407) * 6240c0b Bump test chart dependencies (#402) * c3d1d39 Update to SPIRE 1.10.0 (#393) * 741cd9c Bump test chart dependencies (#398) * c507ee0 Bump test chart dependencies (#397) * 199bb6f Add connect by hostname to agent cofigmap (#392) * eb6d89b Update charts/spire/README.md * c93ad87 Add valid kubectl version to examples * 500fdd9 Bump test chart dependencies (#391) * 08fc5f3 Bump test chart dependencies (#390) * 6904295 Bump test chart dependencies (#389) * fb7fb80 Fix format for ignoreNamespaces (#388) * 7a0a77b Fix host path of "spire-agent-admin-socket-dir" volume (#386) * 1d2d755 Add resource limits for upgrade and delete hook batch jobs (#366) * f7e0d4b Update _spire-system-namespace.yaml (#381) * 29d4b57 Bump test chart dependencies * 4c9059e Bump test chart dependencies (#379) * 1dc650f Apply wildcard for ignoreNamespaces in Controller Manager (#378) * 6c2b5e6 Bump test chart dependencies (#376) Signed-off-by: Faisal Memon <fymemon@yahoo.com>
faisal-memon
added a commit
that referenced
this pull request
Aug 6, 2024
* 82a6d5d Should be `admin_socket_path` not `admin_socket_dir` (#407) * 6240c0b Bump test chart dependencies (#402) * c3d1d39 Update to SPIRE 1.10.0 (#393) * 741cd9c Bump test chart dependencies (#398) * c507ee0 Bump test chart dependencies (#397) * 199bb6f Add connect by hostname to agent cofigmap (#392) * eb6d89b Update charts/spire/README.md * c93ad87 Add valid kubectl version to examples * 500fdd9 Bump test chart dependencies (#391) * 08fc5f3 Bump test chart dependencies (#390) * 6904295 Bump test chart dependencies (#389) * fb7fb80 Fix format for ignoreNamespaces (#388) * 7a0a77b Fix host path of "spire-agent-admin-socket-dir" volume (#386) * 1d2d755 Add resource limits for upgrade and delete hook batch jobs (#366) * f7e0d4b Update _spire-system-namespace.yaml (#381) * 29d4b57 Bump test chart dependencies * 4c9059e Bump test chart dependencies (#379) * 1dc650f Apply wildcard for ignoreNamespaces in Controller Manager (#378) * 6c2b5e6 Bump test chart dependencies (#376) Signed-off-by: Faisal Memon <fymemon@yahoo.com>
faisal-memon
added a commit
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the options that were removed in 1.10, and update.