-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify ingress controller type #43
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
kfox1111
requested review from
marcofranssen,
dfeldman,
faisal-memon and
mrsabath
as code owners
October 18, 2023 16:09
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
Thanks @kfox1111 This will be a nice convenience for ingress users. |
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
kfox1111
force-pushed
the
ingress-type
branch
from
October 19, 2023 14:04
00e7156
to
f609c18
Compare
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
Merged
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
Co-authored-by: Faisal Memon <fymemon@yahoo.com> Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov>
faisal-memon
approved these changes
Oct 20, 2023
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov>
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
kfox1111
force-pushed
the
ingress-type
branch
from
October 24, 2023 20:11
c5727af
to
ed1444c
Compare
faisal-memon
approved these changes
Oct 24, 2023
faisal-memon
added a commit
that referenced
this pull request
Nov 9, 2023
* 6c0a4fb Auto tornjak url (#89) * f2758a8 Autogen jwtIssuer (#88) * 93c20c6 Merge pull request #83 from spiffe/doc-ingress-patch * c662b0c Merge branch 'main' into doc-ingress-patch * de8cbc8 Bump github.com/onsi/gomega from 1.29.0 to 1.30.0 in /tests (#90) * 1de838e Bump helm.sh/helm/v3 from 3.13.1 to 3.13.2 in /tests (#91) * daf9d55 Merge branch 'main' into doc-ingress-patch * aaeca00 Fix tests after renaming files * 0320c3f Cleanup documentation * 37cd9f2 Update to SPIRE 1.8.4 (#84) * bd7879a Fix the typo in the production ingress README * 805d869 spire-controller-manager 0.4.0 support (#60) * edf2381 Bump sigstore/cosign-installer from 3.1.2 to 3.2.0 (#85) * 0ed6d92 Bump test chart dependencies * f7b6140 Fix docs * a7e8785 Add another missing one * 3778597 Add missing ClusterSPIFFEID fields * 9b31f3d Bump helm/chart-testing-action from 2.6.0 to 2.6.1 * d6583be Add missing no cleanup flags to example tests (#79) * 81cc2dc Ingress type openshift (#52) * 2dce90f Bump helm/chart-releaser-action from 1.5.0 to 1.6.0 (#75) * f08ebd3 Patch Tornjak ingress (#74) * 6a6aa1c Cosign download fix (#72) * 3b01684 Support Openshift deployment (#13) * ed23d8b Simple ingress support (#48) * b354413 Fix incorrect nesting of priorityClassName (#67) * 09ebfc9 Bump test chart dependencies (#68) * d50d78d Fix ingress annotation variable for tornjak server (#66) * b813807 Update docs to simplify, clarify, and prioritize ease of install/upgrade (#62) * 5ad35bd Merge pull request #59 from sabre1041/spire-agent-nodename * 02d445c Update charts/spire/README.md * 9bd7f43 Added environment variable to spire-agent to inject node name * fb64f8d Bump github.com/onsi/gomega from 1.28.1 to 1.29.0 in /tests (#61) * 30d0f59 Update helm-charts repository URL (#58) * 7924323 Specify ingress controller type (#43) * 0b17434 Bump test chart dependencies (#54) * a419903 Bump github.com/onsi/gomega from 1.28.0 to 1.28.1 in /tests (#53) * 5025025 Fix doc missing end tag (#46) * cf226a7 Bump actions/checkout from 4.1.0 to 4.1.1 (#42) Signed-off-by: Faisal Memon <fymemon@yahoo.com>
faisal-memon
added a commit
that referenced
this pull request
Nov 9, 2023
* 6c0a4fb Auto tornjak url (#89) * f2758a8 Autogen jwtIssuer (#88) * 93c20c6 Merge pull request #83 from spiffe/doc-ingress-patch * c662b0c Merge branch 'main' into doc-ingress-patch * de8cbc8 Bump github.com/onsi/gomega from 1.29.0 to 1.30.0 in /tests (#90) * 1de838e Bump helm.sh/helm/v3 from 3.13.1 to 3.13.2 in /tests (#91) * daf9d55 Merge branch 'main' into doc-ingress-patch * aaeca00 Fix tests after renaming files * 0320c3f Cleanup documentation * 37cd9f2 Update to SPIRE 1.8.4 (#84) * bd7879a Fix the typo in the production ingress README * 805d869 spire-controller-manager 0.4.0 support (#60) * edf2381 Bump sigstore/cosign-installer from 3.1.2 to 3.2.0 (#85) * 0ed6d92 Bump test chart dependencies * f7b6140 Fix docs * a7e8785 Add another missing one * 3778597 Add missing ClusterSPIFFEID fields * 9b31f3d Bump helm/chart-testing-action from 2.6.0 to 2.6.1 * d6583be Add missing no cleanup flags to example tests (#79) * 81cc2dc Ingress type openshift (#52) * 2dce90f Bump helm/chart-releaser-action from 1.5.0 to 1.6.0 (#75) * f08ebd3 Patch Tornjak ingress (#74) * 6a6aa1c Cosign download fix (#72) * 3b01684 Support Openshift deployment (#13) * ed23d8b Simple ingress support (#48) * b354413 Fix incorrect nesting of priorityClassName (#67) * 09ebfc9 Bump test chart dependencies (#68) * d50d78d Fix ingress annotation variable for tornjak server (#66) * b813807 Update docs to simplify, clarify, and prioritize ease of install/upgrade (#62) * 5ad35bd Merge pull request #59 from sabre1041/spire-agent-nodename * 02d445c Update charts/spire/README.md * 9bd7f43 Added environment variable to spire-agent to inject node name * fb64f8d Bump github.com/onsi/gomega from 1.28.1 to 1.29.0 in /tests (#61) * 30d0f59 Update helm-charts repository URL (#58) * 7924323 Specify ingress controller type (#43) * 0b17434 Bump test chart dependencies (#54) * a419903 Bump github.com/onsi/gomega from 1.28.0 to 1.28.1 in /tests (#53) * 5025025 Fix doc missing end tag (#46) * cf226a7 Bump actions/checkout from 4.1.0 to 4.1.1 (#42) Signed-off-by: Faisal Memon <fymemon@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.