-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to exit on success #116
Conversation
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
Hi @kfox1111 Thanks for the submission. This covers the x509 case. Should the jwt path also have the exit on success? |
Oh, that would be useful too, yeah. I'll see if I can find the other path and update it. |
Actually, I'm confused by how the jwt stuff is working... I only see one exec.Command used:
In the signalProcess method. Which seems to only ever be called in method:
Does the jwt support not support cmds/signals? |
Maybe we should have separate exit configs (one for JWT and one for X509) for now? |
It was decided in discussions not to hold this MR up for this and handle separately. Created #121 for this. |
The README never got updated for this feature. |
This PR allows the spiffe-helper to exit 0 after certificates have been retrieved. This can be used in conjunction with Kubernetes initContainers to ensure certificates are retrieved before running the spiffe-helper as a sidecar container.
Partially implements: #115