Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move disk related functions to pkg/disk #138

Merged
merged 11 commits into from
Mar 7, 2024
Merged

Move disk related functions to pkg/disk #138

merged 11 commits into from
Mar 7, 2024

Conversation

faisal-memon
Copy link
Collaborator

Refactor that consolidates all disk function in the pkg/ folder.

Copy link
Contributor

@kfox1111 kfox1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

pkg/disk/json.go Outdated Show resolved Hide resolved
pkg/disk/json.go Outdated Show resolved Hide resolved
pkg/disk/json.go Outdated Show resolved Hide resolved
pkg/disk/json.go Outdated Show resolved Hide resolved
pkg/disk/json_test.go Outdated Show resolved Hide resolved
pkg/disk/json_test.go Outdated Show resolved Hide resolved
pkg/disk/x509.go Outdated Show resolved Hide resolved
pkg/disk/x509.go Outdated Show resolved Hide resolved
pkg/disk/x509_test.go Outdated Show resolved Hide resolved
pkg/disk/x509_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@MarcosDY MarcosDY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but can you resolve DCO?

faisal-memon and others added 10 commits March 7, 2024 09:49
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
Co-authored-by: Marcos Yacob <marcos.yacob@hpe.com>
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
Co-authored-by: Marcos Yacob <marcos.yacob@hpe.com>
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
Co-authored-by: Marcos Yacob <marcos.yacob@hpe.com>
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
Co-authored-by: Marcos Yacob <marcos.yacob@hpe.com>
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
@faisal-memon faisal-memon merged commit a67c8d1 into main Mar 7, 2024
12 checks passed
@faisal-memon faisal-memon deleted the disk branch March 7, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants