Move envs to bottom to avoid docker re-builds, and fix python dependency versions #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
spillai
commented
Oct 18, 2023
•
spillai
commented
- only base images get to define python versions, all others are enforced to use the same version
- move ENV definitions to the bottom of the Dockerfile to avoid re-building the image when the envs change
…ncy versions
- only base images get to define python versions, all
others are enforced to use the same version
- move ENV definitions to the bottom of the Dockerfile to
avoid re-building the image when the envs change
spillai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.