Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stages/bakeManifests): add helmfile support #9998

Merged

Conversation

thameezb
Copy link
Contributor

Related to spinnaker/spinnaker#6837

Adds in support for helmfile as a "Render Engine" in the "Bake (Manifest)" stage.

Relies on spinnaker/rosco#986 and spinnaker/orca#4460

@thameezb thameezb marked this pull request as draft May 26, 2023 15:53
@thameezb thameezb force-pushed the feat-6837/addHelmfileTemplatingEngine branch from 1dd0f33 to e881df4 Compare June 5, 2023 15:15
@thameezb thameezb force-pushed the feat-6837/addHelmfileTemplatingEngine branch from e881df4 to ca760ed Compare June 6, 2023 07:55
@thameezb thameezb marked this pull request as ready for review June 12, 2023 12:45
Copy link
Contributor

@ovidiupopa07 ovidiupopa07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

The only thing that I noticed is some duplicate code between BakeHelmFileConfigForm and BakeHelmConfigForm.

@ovidiupopa07
Copy link
Contributor

I will add the ready-to-merge label to this one considering that the other 2 PRs are already merged, and more importantly, this feature is already used and works fine.

@ovidiupopa07 ovidiupopa07 added the ready to merge Reviewed and ready for merge label Jul 20, 2023
@mergify mergify bot added the auto merged Merged automatically by a bot label Jul 20, 2023
@mergify mergify bot merged commit a4a0f33 into spinnaker:master Jul 20, 2023
4 checks passed
sahititarigoppula pushed a commit to OpsMx/deck-oes that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Reviewed and ready for merge target-release/1.32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants