refactor: Refactor how the kayenta object mapper is being configured to allow overriding from kayenta plugins #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to allow overriding from kayenta plugins - ObjectMapperSubtypeConfigurer objectMapperSubtypeConfigurer is defined as a bean - there's no need to autowire the mapper to configure but instead configure it when creating the kayentaObjectMapper bean
dogonthehorizon
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you define a new subtype locator in a plugin it is not possible to be loaded by the configurer because different classloaders are used. This refactoring will give the flexibility of customizing the
ObjectMapperSubtypeConfigurerfrom the plugin systemThis will allow us to add more metrics providers (via the plugin framework)