Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependency): unpin mysql-connector-java and liquibase-core #1037

Merged
merged 1 commit into from
May 16, 2024

Conversation

j-sandy
Copy link
Contributor

@j-sandy j-sandy commented May 16, 2024

mysql-connector-java and liquibase-core are transitive dependencies part of orca-bom.

Before:

$ ./gradlew kayenta-sql:dI --dependency mysql-connector-java --configuration runtimeClasspath

> Task :kayenta-sql:dependencyInsight
mysql:mysql-connector-java:8.0.33
  Variant runtime:
    | Attribute Name                 | Provided     | Requested    |
    |--------------------------------|--------------|--------------|
    | org.gradle.status              | release      |              |
    | org.gradle.category            | library      | library      |
    | org.gradle.libraryelements     | jar          | jar          |
    | org.gradle.usage               | java-runtime | java-runtime |
    | org.gradle.dependency.bundling |              | external     |
    | org.gradle.jvm.environment     |              | standard-jvm |
    | org.gradle.jvm.version         |              | 11           |
   Selection reasons:
      - By constraint
      - Forced

mysql:mysql-connector-java:8.0.33
\--- io.spinnaker.orca:orca-bom:8.51.0
     +--- runtimeClasspath
     \--- project :kayenta-core
          \--- runtimeClasspath

mysql:mysql-connector-java:8.0.25 -> 8.0.33
\--- runtimeClasspath

(*) - dependencies omitted (listed previously)

After:

$ ./gradlew kayenta-sql:dI --dependency mysql-connector-java --configuration runtimeClasspath

> Task :kayenta-sql:dependencyInsight
mysql:mysql-connector-java:8.0.33
  Variant runtime:
    | Attribute Name                 | Provided     | Requested    |
    |--------------------------------|--------------|--------------|
    | org.gradle.status              | release      |              |
    | org.gradle.category            | library      | library      |
    | org.gradle.libraryelements     | jar          | jar          |
    | org.gradle.usage               | java-runtime | java-runtime |
    | org.gradle.dependency.bundling |              | external     |
    | org.gradle.jvm.environment     |              | standard-jvm |
    | org.gradle.jvm.version         |              | 11           |
   Selection reasons:
      - By constraint
      - Forced

mysql:mysql-connector-java:8.0.33
\--- io.spinnaker.orca:orca-bom:8.51.0
     +--- runtimeClasspath
     \--- project :kayenta-core
          \--- runtimeClasspath

mysql:mysql-connector-java -> 8.0.33
\--- runtimeClasspath

(*) - dependencies omitted (listed previously)

Before:

$ ./gradlew kayenta-sql:dI --dependency liquibase-core

> Task :kayenta-sql:dependencyInsight
org.liquibase:liquibase-core:4.24.0
  Variant compile:
    | Attribute Name                 | Provided | Requested         |
    |--------------------------------|----------|-------------------|
    | org.gradle.status              | release  |                   |
    | org.gradle.category            | library  | library           |
    | org.gradle.libraryelements     | jar      | classes+resources |
    | org.gradle.usage               | java-api | java-api          |
    | org.gradle.dependency.bundling |          | external          |
    | org.gradle.jvm.environment     |          | standard-jvm      |
    | org.gradle.jvm.version         |          | 11                |
   Selection reasons:
      - By constraint
      - Forced

org.liquibase:liquibase-core:4.24.0
\--- io.spinnaker.orca:orca-bom:8.51.0
     \--- compileClasspath

org.liquibase:liquibase-core:4.20.0 -> 4.24.0
\--- compileClasspath

After:

$ ./gradlew kayenta-sql:dI --dependency liquibase-core

> Task :kayenta-sql:dependencyInsight
org.liquibase:liquibase-core:4.24.0
  Variant compile:
    | Attribute Name                 | Provided | Requested         |
    |--------------------------------|----------|-------------------|
    | org.gradle.status              | release  |                   |
    | org.gradle.category            | library  | library           |
    | org.gradle.libraryelements     | jar      | classes+resources |
    | org.gradle.usage               | java-api | java-api          |
    | org.gradle.dependency.bundling |          | external          |
    | org.gradle.jvm.environment     |          | standard-jvm      |
    | org.gradle.jvm.version         |          | 11                |
   Selection reasons:
      - By constraint
      - Forced

org.liquibase:liquibase-core:4.24.0
\--- io.spinnaker.orca:orca-bom:8.51.0
     \--- compileClasspath

org.liquibase:liquibase-core -> 4.24.0
\--- compileClasspath

mysql-connector-java and liquibase-core are transitive dependencies part of orca-bom.

Before:
```
$ ./gradlew kayenta-sql:dI --dependency mysql-connector-java --configuration runtimeClasspath

> Task :kayenta-sql:dependencyInsight
mysql:mysql-connector-java:8.0.33
  Variant runtime:
    | Attribute Name                 | Provided     | Requested    |
    |--------------------------------|--------------|--------------|
    | org.gradle.status              | release      |              |
    | org.gradle.category            | library      | library      |
    | org.gradle.libraryelements     | jar          | jar          |
    | org.gradle.usage               | java-runtime | java-runtime |
    | org.gradle.dependency.bundling |              | external     |
    | org.gradle.jvm.environment     |              | standard-jvm |
    | org.gradle.jvm.version         |              | 11           |
   Selection reasons:
      - By constraint
      - Forced

mysql:mysql-connector-java:8.0.33
\--- io.spinnaker.orca:orca-bom:8.51.0
     +--- runtimeClasspath
     \--- project :kayenta-core
          \--- runtimeClasspath

mysql:mysql-connector-java:8.0.25 -> 8.0.33
\--- runtimeClasspath

(*) - dependencies omitted (listed previously)
```

After:
```
$ ./gradlew kayenta-sql:dI --dependency mysql-connector-java --configuration runtimeClasspath

> Task :kayenta-sql:dependencyInsight
mysql:mysql-connector-java:8.0.33
  Variant runtime:
    | Attribute Name                 | Provided     | Requested    |
    |--------------------------------|--------------|--------------|
    | org.gradle.status              | release      |              |
    | org.gradle.category            | library      | library      |
    | org.gradle.libraryelements     | jar          | jar          |
    | org.gradle.usage               | java-runtime | java-runtime |
    | org.gradle.dependency.bundling |              | external     |
    | org.gradle.jvm.environment     |              | standard-jvm |
    | org.gradle.jvm.version         |              | 11           |
   Selection reasons:
      - By constraint
      - Forced

mysql:mysql-connector-java:8.0.33
\--- io.spinnaker.orca:orca-bom:8.51.0
     +--- runtimeClasspath
     \--- project :kayenta-core
          \--- runtimeClasspath

mysql:mysql-connector-java -> 8.0.33
\--- runtimeClasspath

(*) - dependencies omitted (listed previously)

```

Before:
```
$ ./gradlew kayenta-sql:dI --dependency liquibase-core

> Task :kayenta-sql:dependencyInsight
org.liquibase:liquibase-core:4.24.0
  Variant compile:
    | Attribute Name                 | Provided | Requested         |
    |--------------------------------|----------|-------------------|
    | org.gradle.status              | release  |                   |
    | org.gradle.category            | library  | library           |
    | org.gradle.libraryelements     | jar      | classes+resources |
    | org.gradle.usage               | java-api | java-api          |
    | org.gradle.dependency.bundling |          | external          |
    | org.gradle.jvm.environment     |          | standard-jvm      |
    | org.gradle.jvm.version         |          | 11                |
   Selection reasons:
      - By constraint
      - Forced

org.liquibase:liquibase-core:4.24.0
\--- io.spinnaker.orca:orca-bom:8.51.0
     \--- compileClasspath

org.liquibase:liquibase-core:4.20.0 -> 4.24.0
\--- compileClasspath
```

After:
```
$ ./gradlew kayenta-sql:dI --dependency liquibase-core

> Task :kayenta-sql:dependencyInsight
org.liquibase:liquibase-core:4.24.0
  Variant compile:
    | Attribute Name                 | Provided | Requested         |
    |--------------------------------|----------|-------------------|
    | org.gradle.status              | release  |                   |
    | org.gradle.category            | library  | library           |
    | org.gradle.libraryelements     | jar      | classes+resources |
    | org.gradle.usage               | java-api | java-api          |
    | org.gradle.dependency.bundling |          | external          |
    | org.gradle.jvm.environment     |          | standard-jvm      |
    | org.gradle.jvm.version         |          | 11                |
   Selection reasons:
      - By constraint
      - Forced

org.liquibase:liquibase-core:4.24.0
\--- io.spinnaker.orca:orca-bom:8.51.0
     \--- compileClasspath

org.liquibase:liquibase-core -> 4.24.0
\--- compileClasspath

```
@dbyron-sf dbyron-sf added the ready to merge Reviewed and ready for merge label May 16, 2024
@mergify mergify bot added the auto merged label May 16, 2024
@mergify mergify bot merged commit 0aebe78 into spinnaker:master May 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants