refactor(tests): convert junit4 based testcases to junit5 and clean up in kayenta #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbyron-sf
reviewed
Jul 21, 2023
dbyron-sf
reviewed
Jul 21, 2023
kayenta-core/src/test/groovy/com/netflix/kayenta/metrics/SynchronousQueryProcessorTest.java
Outdated
Show resolved
Hide resolved
dbyron-sf
approved these changes
Jul 26, 2023
|
The plan is to figure out the missing test cases as we upgrade spock / move to groovy 3, right? |
Yes, that is the plan. |
j-sandy
force-pushed
the
junit4to5
branch
2 times, most recently
from
56cf912
to
40e7710
Compare
|
The reason for less coverage is undetected scala based junit4 test cases in kayenta-mannwhitney and kayenta-judge modules. To fix the coverage, converted them into junit5. Now, after refactor, total test cases executed are 420. |
dbyron-sf
reviewed
Sep 29, 2023
...ta-influxdb/src/test/java/com/netflix/kayenta/influxdb/service/InfluxdbQueryBuilderTest.java
Outdated
Show resolved
Hide resolved
…p in kayenta Before refactor, total test cases executed were 336. After refactor, total test cases executed are 420.
dbyron-sf
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before refactor, total test cases executed were 336.
After refactor, total test cases executed are
326420.