refactor(manifests): use new methods in manifest exception handling (#…

…983)

* refactor(manifests): use new methods in manifest exception handling

Uses the newInstance method on the SpinnakerException to clean up some exception handling in ArtifactDownloaderImpl.

* refactor(manifest): formatter

Ran formatter, deleted unnecessary import.

---------

Co-authored-by: Richard Timpson <richard.timpson@salesforce.com>

rosco-manifests/src/main/java/com/netflix/spinnaker/rosco/manifests/ArtifactDownloaderImpl.java

@@ -4,7 +4,6 @@
 import com.netflix.spinnaker.kork.core.RetrySupport;
 import com.netflix.spinnaker.kork.exceptions.SpinnakerException;
 import com.netflix.spinnaker.kork.retrofit.Retrofit2SyncCall;
-import com.netflix.spinnaker.kork.retrofit.exceptions.SpinnakerHttpException;
 import com.netflix.spinnaker.rosco.services.ClouddriverService;
 import java.io.IOException;
 import java.io.InputStream;
@@ -50,10 +49,8 @@ public void downloadArtifactToFile(Artifact artifact, Path targetFile) throws IO
                 artifact, e.getMessage()),
             e);
       }
-    } catch (SpinnakerHttpException e) {
-      throw new SpinnakerHttpException(downloadFailureMessage(artifact, e), e);
     } catch (SpinnakerException e) {
-      throw new SpinnakerException(downloadFailureMessage(artifact, e), e);
+      throw e.newInstance(downloadFailureMessage(artifact, e));
     }
   }