Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manifests/helmfile): add helmfile templating engine #986

Merged
merged 15 commits into from
Jul 14, 2023
Merged

feat(manifests/helmfile): add helmfile templating engine #986

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e4f9508
feat(manifests/helmfile): install helmfile binary
thameezb May 22, 2023
95ff86b
feat(manifests/helmfile): add code
thameezb May 23, 2023
30ad3e3
copyright
mazzy89 Jun 20, 2023
997a574
test changes
mazzy89 Jun 20, 2023
a67d35d
add javadoc
mazzy89 Jun 20, 2023
7e1f516
make the code dry
mazzy89 Jun 22, 2023
256756c
reduce value paths
mazzy89 Jun 22, 2023
3985c81
Merge branch 'master' into feat-6837/addHelmfileTemplatingEngine
jasonmcintosh Jul 5, 2023
c0ceabc
avoid using wildcards
mazzy89 Jul 10, 2023
f2ac9e0
reduce redundant code
mazzy89 Jul 10, 2023
f877ba0
increase reuse
mazzy89 Jul 10, 2023
7c469ed
Merge branch 'master' into feat-6837/addHelmfileTemplatingEngine
mazzy89 Jul 12, 2023
3e86a4b
run spotless
mazzy89 Jul 13, 2023
54249e2
run another round of spotless
mazzy89 Jul 13, 2023
6997196
Merge branch 'master' into feat-6837/addHelmfileTemplatingEngine
mazzy89 Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Dockerfile.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ LABEL maintainer="sig-platform@spinnaker.io"
ENV KUSTOMIZE_VERSION=3.8.6
ENV KUSTOMIZE4_VERSION=4.5.5
ENV PACKER_VERSION=1.8.1
ENV HELMFILE_VERSION=0.153.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that 0.154.0 has now appeared. I'm OK to go ahead with 0.153.1 and update in a follow-up PR.

Copy link
Contributor

@mazzy89 mazzy89 Jul 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this PR, 0.155.0 has come out. Once this will be merged we are going to bump the version of helmfile.



ARG TARGETARCH
Expand Down Expand Up @@ -42,6 +43,12 @@ RUN mkdir kustomize && \
mv ./kustomize/kustomize /usr/local/bin/kustomize4 && \
rm -rf ./kustomize

RUN mkdir helmfile && \
curl -s -L https://github.com/helmfile/helmfile/releases/download/v${HELMFILE_VERSION}/helmfile_${HELMFILE_VERSION}_linux_${TARGETARCH}.tar.gz|\
tar xvz -C helmfile/ && \
mv ./helmfile/helmfile /usr/local/bin/helmfile && \
rm -rf ./helmfile

RUN addgroup -S -g 10111 spinnaker
RUN adduser -S -G spinnaker -u 10111 spinnaker
COPY rosco-web/build/install/rosco /opt/rosco
Expand Down
7 changes: 7 additions & 0 deletions Dockerfile.ubuntu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ LABEL maintainer="sig-platform@spinnaker.io"
ENV KUSTOMIZE_VERSION=3.8.6
ENV KUSTOMIZE4_VERSION=4.5.5
ENV PACKER_VERSION=1.8.1
ENV HELMFILE_VERSION=0.153.1

ARG TARGETARCH

Expand Down Expand Up @@ -41,6 +42,12 @@ RUN mkdir kustomize && \
mv ./kustomize/kustomize /usr/local/bin/kustomize4 && \
rm -rf ./kustomize

RUN mkdir helmfile && \
curl -s -L https://github.com/helmfile/helmfile/releases/download/v${HELMFILE_VERSION}/helmfile_${HELMFILE_VERSION}_linux_${TARGETARCH}.tar.gz|\
tar xvz -C helmfile/ && \
mv ./helmfile/helmfile /usr/local/bin/helmfile && \
rm -rf ./helmfile

RUN adduser --system --uid 10111 --group spinnaker
COPY rosco-web/build/install/rosco /opt/rosco
COPY rosco-web/config /opt/rosco
Expand Down