Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FlexBuffer serialization ambiguity for binary/string/list(u8) #1859

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

a10y
Copy link
Contributor

@a10y a10y commented Jan 8, 2025

After the recent switch to ByteBuffer, FlexBuffer would have am ambiguity serializing the different sequence variants. This was resulting in Binary ScalarValues written to files to be reinterpreted as List(u8) on read.

Instead, we explicitly handle serialization.

Part of #1749

After the recent switch to ByteBuffer, FlexBuffer would have am ambiguity
serializing the different sequence variants. This was resulting in
Binary ScalarValues written to files to be reinterpreted as List(u8)
on read.

Instead, we explicitly handle serialization.
@a10y a10y force-pushed the aduffy/debug-list-issue branch from e50eed6 to da2d5cd Compare January 8, 2025 19:36
@a10y a10y enabled auto-merge (squash) January 8, 2025 19:37
@a10y a10y merged commit 01f4f92 into develop Jan 8, 2025
21 checks passed
@a10y a10y deleted the aduffy/debug-list-issue branch January 8, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants