Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python3 support and a tiny bit of "PEP8"-ing #18

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Python3 support and a tiny bit of "PEP8"-ing #18

wants to merge 5 commits into from

Conversation

DeepSpace2
Copy link

  • file -> open
  • "except Exception, e" -> "except Exception as e"
  • separating imports
  • Importing configparser as fallback if ConfigParser fails to be imported (basically means Python 3)

@DeepSpace2 DeepSpace2 mentioned this pull request Sep 14, 2016
Closed
@szepeviktor
Copy link

I had the ValueError: can't have unbuffered text I/O issue in #6.

Have you fixed it?

@DeepSpace2
Copy link
Author

Seems like it, I didn't get it during my testing. Can you please verify it on you machine (even without accepting my pull request, you can clone it directly from my repo ? If it still happens on your machine let me know in which line and I'll have a deeper look.

@DeepSpace2
Copy link
Author

So today I got that ValueError exception. I fixed it in my latest commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DeepSpace2 @szepeviktor @klemens-u