Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReversingLabs-TitaniumCloud v2: Other - Update version of ReversingLabs SDK and dependency libraries due to known vulnerabilities #17

Merged
merged 17 commits into from
Oct 29, 2024

Conversation

DinkoReversingLabs
Copy link
Collaborator

Please ensure your pull request (PR) adheres to the following guidelines:

  • Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist

Please check if your PR fulfills the following requirements:

  • Testing of all the changes has been performed (for bug fixes / features)
  • The manual_readme_content.md has been reviewed and added / updated if needed (for bug fixes / features)
  • Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
  • Verify all checks are passing.
  • Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
  • Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type

Please check the type of change your PR introduces:

  • New App
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation
  • Other (please describe): Update on libraries which contain security vulnerabilities reported

Security Considerations (REQUIRED)

  • If you are exposing any endpoints using a REST handler,
    please document them in the manual_readme_content.md.
  • If this is a new connector or you are adding new actions
    • Please document in the manual_readme_content.md all methods (eg, OAuth) used to authenticate
      with the service that the connector is integrating with.
    • If any actions are unable to run on SOAR Cloud, please document this in the manual_readme_content.md.
  • Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
  • Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
    the Vault API.
  • Are you are marking code to be ignored by Semgrep with nosemgrep?
    If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.

What is the current behavior? (OPTIONAL)

  • Describe the current behavior that you are modifying.

What is the new behavior? (OPTIONAL)

  • Describe the behavior or changes that are being added by this PR.

Other information (OPTIONAL)

  • Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

  • Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)


Thanks for contributing!

Added initial pipeline

See merge request integrations/marketplace/splunk/reversinglabs-ticloudv2!2
Bump version of RL SDK and dependencies

See merge request integrations/marketplace/splunk/reversinglabs-ticloudv2!3
@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

Sorting and Linting

See merge request integrations/marketplace/splunk/reversinglabs-ticloudv2!5
@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

Added new config for linting and formatting

See merge request integrations/marketplace/splunk/reversinglabs-ticloudv2!6
@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

Isort

See merge request integrations/marketplace/splunk/reversinglabs-ticloudv2!7
@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

Linting

See merge request integrations/marketplace/splunk/reversinglabs-ticloudv2!9
@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@DinkoReversingLabs
Copy link
Collaborator Author

@mishalp-crest @ishans-crest

We are having an issue with deploying newly added changes to repo due to linting in your github action. I have tried to replicate steps from github actions with same python version and config from https://github.com/phantomcyber/dev-cicd-tools

In our case sorting (isort) and formatting (black) exclude each other. Changes that apply these tool on code prevents pipeline. If you try to add suggested changes from one tool it breaks the other tool.

Could you check outputs from pipeline execution and help us with this issue.

Kind regards
Dinko

@ishans-crest
Copy link
Contributor

@mishalp-crest @ishans-crest

We are having an issue with deploying newly added changes to repo due to linting in your github action. I have tried to replicate steps from github actions with same python version and config from https://github.com/phantomcyber/dev-cicd-tools

In our case sorting (isort) and formatting (black) exclude each other. Changes that apply these tool on code prevents pipeline. If you try to add suggested changes from one tool it breaks the other tool.

Could you check outputs from pipeline execution and help us with this issue.

Kind regards Dinko

Thanks for reaching out, this is known issue. We are fixing it and releasing a new patch soon.

@DinkoReversingLabs
Copy link
Collaborator Author

out, this is known issue. We are fixing it and releasing a new patch soon.

Hi @ishans-crest,

do you have some ETA on fix? We would like to plan this release notification and other activities related to the updated connector.

Kind regards
Dinko

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@DinkoReversingLabs DinkoReversingLabs merged commit 3c729af into splunk-soar-connectors:next Oct 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants