Nterl0k pingid mfa #846
Merged
Nterl0k pingid mfa #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nterl0k : can you add a yaml file explaining this dataset |
|
Oversight on my part, will do directly. Sorry about that.
Regards,
Steven.
…-------- Original message --------
From: Bhavin Patel ***@***.***>
Date: 10/23/23 3:11 PM (GMT-05:00)
To: splunk/attack_data ***@***.***>
Cc: Steven Dick ***@***.***>, Mention ***@***.***>
Subject: Re: [splunk/attack_data] Nterl0k pingid mfa (PR #846)
@nterl0k<https://github.com/nterl0k> : can you add a yaml file explaining this dataset
EG: https://github.com/splunk/attack_data/blob/master/datasets/attack_techniques/T1003.001/atomic_red_team/atomic_red_team.yml
—
Reply to this email directly, view it on GitHub<#846 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJIYP7WHEICC7ARANGNOGKTYA26OBAVCNFSM6AAAAAA6FPUTLOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZVHA3DCMZTGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Also, these datasets are probably not uploaded via git lfs , upload it via lfs so that it is available as a media. Thank you! |
|
@patel-bhavin uploaded a dataset yaml and reuploaded the log files. |
minor yaml changes
patel-bhavin
approved these changes
Oct 25, 2023
|
minor yaml changes and the PR looks good, merged for testing the detections |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PingID/PingOne dataset for upcoming detection PR.