Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: basic helm3 support as a datasource #265

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

WIP: basic helm3 support as a datasource #265

wants to merge 2 commits into from

Conversation

gotwarlost
Copy link
Contributor

@gotwarlost gotwarlost commented Oct 10, 2021

Implements a custom helm3 data source and provides examples of use, using a pattern that keeps all helm3 values and configuration in one place with the exception of the computed var entry that is needed in qbec.yaml. This is as close as I can get without having a bunch of unrelated files in random places each of which contributes to the final result.

The victoria-metrics component does not work because I think it needs some good values to be set. It shows you what happens on an error though.

$ # checkout this branch
$ cd examples/helm3
$ qbec show default -c apache # works
$ qbec show default -c victoria-metrics # prints multiple pages of errors right now

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2021

Codecov Report

Merging #265 (d0407db) into main (2ae1106) will decrease coverage by 1.45%.
The diff coverage is 19.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
- Coverage   74.13%   72.68%   -1.46%     
==========================================
  Files          72       73       +1     
  Lines        6933     7121     +188     
==========================================
+ Hits         5140     5176      +36     
- Misses       1585     1737     +152     
  Partials      208      208              
Impacted Files Coverage Δ
vm/internal/ds/factory/datasource.go 82.14% <0.00%> (-9.86%) ⬇️
vm/internal/ds/helm3/helm3.go 19.45% <19.45%> (ø)
vm/internal/ds/exec/exec.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ae1106...d0407db. Read the comment docs.

@gotwarlost gotwarlost changed the title Draft: basic helm3 support as a datasource WIP: basic helm3 support as a datasource Oct 10, 2021
@gotwarlost
Copy link
Contributor Author

@Andor @kvaps - any feedback?

@Andor
Copy link

Andor commented Oct 15, 2021

Sorry, I did not try it yet and not sure will I have time to test it in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants