-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Inactive Account Have Activity Detected" #3160
Conversation
Detection Metadata Validation:
|
Yes, like @ljstella mentioned - we are working on getting tooling and git actions a bit straightened out. We will keep you updated! and thank you contributing to security_content! |
Hello @zake1god : thank you for your patience! We have recently updated our tooling and have some general feedback about the detection. I will leave some inline comments on how we can improve this before we ship this detection. |
tests: | ||
- name: True Positive Test | ||
attack_data: | ||
- data: https://github.com/splunk/contentctl/wiki |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zake1god : Do you have raw events that we can use in to test this detection against? :
Can you perhaps upload that data to - https://github.com/splunk/attack_data repo. You can use this directory for hosting your data : https://github.com/splunk/attack_data/tree/master/datasets/suspicious_behaviour
Fix name, Fix data_sources, Change type, Add drilldown_searches, Add analytic_story
Hello @zake1god : based on this CI failure: https://github.com/splunk/security_content/actions/runs/11487045805/job/31970703528?pr=3160 You likely need to update the file name to match the detection name |
…traffic_from_inactive_accounts_filter.yml Rename for fix CI
Hi @patel-bhavin i already update the file name to match the detection name, and already update filter name. For raw events i can't get but i can create it. it must be like this |
…tect_network_traffic_from_inactive_accounts.yml Wrong name, and already fix it
Already fix some wrong code in title and in body |
Did i need to fix something? Already got All checks have passed @patel-bhavin @ljstella |
Hello @zake1god - seems like this detection is now passing Example of attack data link in the detection yaml. We would need raw events that are associated with this detection to test this detection. Would you be able to dump that from any test splunk instance? Also, can you please attach a screenshot of the search execution? |
detections/network/detect_network_traffic_from_inactive_accounts.yml
Outdated
Show resolved
Hide resolved
detections/network/detect_network_traffic_from_inactive_accounts.yml
Outdated
Show resolved
Hide resolved
- Windows Event Log Security 4625 | ||
type: Anomaly | ||
status: production | ||
description: This detection identifies users who have been inactive for more than 30 days and suddenly have activity based on network traffic logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we improve the detection description to better explain how this search logic works?
detections/network/detect_network_traffic_from_inactive_accounts.yml
Outdated
Show resolved
Hide resolved
Improve detection description, Remove %original_detection_search% and endhoursago=1, Update message from Analytic Story, Update risk_score
Hi @ljstella thankyou for your review. Already change it, and i open PR in Splunk/Attack_Data in here : splunk/attack_data#912 |
@zake1god : Nice work on addressing the comment and the attack data PR. We would need _raw events from a sourcetype that maps to the network traffic datamodel : ex - Palo Alto Logs. A json file like the one you submitted would not work with our testing pipeline. Can you share what sourcetype did you use to develop this search? Can you perhaps share an raw events from that environment that can help trigger this detection in a splunk instance? The attack data PR you created looks good but we will will need raw events to successfully test this detection! |
also, I am curious that you have mentioned these in the data_sources field. Do these map to the network traffic data model?
I see that your detection uses |
Omg, when i go verification again its wrong target. My bad, i'm so sorry for this. |
Details
This PR introduces a new detection for Inactive User Have Activity Detected. This detection identifies users who have been inactive for more than 30 days and suddenly have activity based on network traffic logs.
Screenshots/Examples :
Checklist
<platform>_<mitre att&ck technique>_<short description>
nomenclatureNotes For Submitters and Reviewers
build
CI job when it fails will likely show an error about what is failing. You may have a very descriptive error of the specific field(s) in the specific file(s) that is causing an issue. In some cases, it's also possible there is an issue with the YAML. Many of these can be caught with the pre-commit hooks if you set them up. These errors will be less descriptive as to what exactly is wrong but will give you a column and row position in a specific file where the YAML processing breaks. If you're having trouble with this, feel free to add a comment to your PR tagging one of the maintainers, and we'll be happy to help troubleshoot it.