Skip to content

Commit

Permalink
set protocol https for .Status.Address.URL
Browse files Browse the repository at this point in the history
Signed-off-by: jooho lee <jlee@redhat.com>
  • Loading branch information
Jooho committed Jul 18, 2024
1 parent 4259287 commit 6bacfbf
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pkg/controller/v1beta1/inferenceservice/controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1871,7 +1871,7 @@ var _ = Describe("v1beta1 inference service controller", func() {
Host: constants.InferenceServiceHostName(constants.PredictorServiceName(serviceKey.Name), serviceKey.Namespace, domain),
}))
Expect(actualIsvc.Status.Address.URL).To(gomega.Equal(&apis.URL{
Scheme: "http",
Scheme: "https",
Host: network.GetServiceHostname(fmt.Sprintf("%s-%s", serviceKey.Name, string(constants.Predictor)), serviceKey.Namespace),
}))
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,7 @@ func (ir *IngressReconciler) Reconcile(isvc *v1beta1.InferenceService) error {
isvc.Status.Address = &duckv1.Addressable{
URL: &apis.URL{
Host: network.GetServiceHostname(hostPrefix, isvc.Namespace),
Scheme: "http",
Scheme: "https",
},
}
isvc.Status.SetCondition(v1beta1.IngressReady, &apis.Condition{
Expand Down

0 comments on commit 6bacfbf

Please sign in to comment.