Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade starlette from 0.22.0 to 0.27.0 #183

Closed

Conversation

spolti
Copy link
Owner

@spolti spolti commented Apr 11, 2024

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `pip` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • docs/samples/v1beta1/triton/fastertransformer/transformer/requirements.txt
⚠️ Warning
ray 2.0.0 has requirement grpcio<=1.43.0,>=1.28.1; python_version < "3.10", but you have grpcio 1.62.1.
ray 2.0.0 has requirement protobuf<4.0.0,>=3.15.3, but you have protobuf 4.24.4.
kserve 0.10.2 has requirement numpy>=1.21.5, but you have numpy 1.21.3.
fastapi 0.88.0 has requirement starlette==0.22.0, but you have starlette 0.29.0.
fastapi 0.88.0 has requirement pydantic!=1.7,!=1.7.1,!=1.7.2,!=1.7.3,!=1.8,!=1.8.1,<2.0.0,>=1.6.2, but you have pydantic 2.5.3.
botocore 1.33.13 has requirement urllib3<1.27,>=1.25.4; python_version < "3.10", but you have urllib3 2.0.7.

Vulnerabilities that will be fixed

By pinning:
Severity Issue Upgrade Breaking Change Exploit Maturity
medium severity Denial of Service (DoS)
SNYK-PYTHON-STARLETTE-3319937
starlette:
0.22.0 -> 0.27.0
No No Known Exploit
high severity Directory Traversal
SNYK-PYTHON-STARLETTE-5538332
starlette:
0.22.0 -> 0.27.0
No Proof of Concept

Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Denial of Service (DoS)
🦉 Directory Traversal

spolti and others added 3 commits April 11, 2024 15:25
Fixes:	[CVE-2020-26521](https://www.cve.org/CVERecord?id=CVE-2020-26521)
	[CVE-2020-28466](https://www.cve.org/CVERecord?id=CVE-2020-28466)
	[CVE-2022-42709](https://www.cve.org/CVERecord?id=CVE-2022-42709)
	[CVE-2023-46129](https://www.cve.org/CVERecord?id=CVE-2023-46129)

On RHOAI it seems that it was added manually as indirect dependency, but if you
run `go mod tidy` the nats dependencies would be removed.
Pinning it to avoid it.

Signed-off-by: Spolti <fspolti@redhat.com>
…ements.txt to reduce vulnerabilities

The following vulnerabilities are fixed by pinning transitive dependencies:
- https://snyk.io/vuln/SNYK-PYTHON-STARLETTE-3319937
- https://snyk.io/vuln/SNYK-PYTHON-STARLETTE-5538332
spolti pushed a commit that referenced this pull request Apr 17, 2024
@spolti spolti closed this Jun 26, 2024
@spolti spolti deleted the snyk-fix-553d42f48fe37cffe829865dfa8056a7 branch June 26, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants