Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Support different node/group setup): Support different node/group setup #79

Merged
merged 7 commits into from
May 23, 2024

Conversation

eoctodolphin
Copy link
Collaborator

Vespa support multiple ways of configuring group/nodes/node. See services.xml.
Screenshot 2024-05-22 at 11 39 52

This PR fix content tab for all those setups:

  • Content with no group (only nodes with multiple node)
  • Content with no group (only nodes and one node) - single host setup
  • Content with single group with only one none - single host setup
  • Content with single group multiple node

@eoctodolphin eoctodolphin changed the title feat(Support all node/group configuration): Support all node/group configuration feat(Support different node/group setup): Support different node/group setup May 22, 2024
@JacksonXmlProperty(localName = "nodes")
Nodes nodes;

public List<Group> getGroups() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 I thought it would be a lot more complicated, nice!

Copy link
Collaborator

@pfrybar pfrybar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small question, but otherwise looks great.

@pfrybar pfrybar merged commit 434b8dc into spotify:main May 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants