Skip to content

Commit

Permalink
increase nginx body size limit (#192)
Browse files Browse the repository at this point in the history
when uploading files from JupyterLab, the chunks sometimes are bigger
than the expected 1MB.
This increase the limit to 2MB, it should be enough.
Same change will be done in CP ingress

Co-authored-by: Emmanuel Pignot <emmanuel.pignot@netapp.com>
  • Loading branch information
epignot and Emmanuel Pignot authored Mar 27, 2024
1 parent 71c271b commit 79c9fe2
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion charts/bigdata-proxy/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: bigdata-proxy
description: A Helm chart for the Spot Big Data Proxy
type: application
version: 0.4.5
version: 0.4.6
appVersion: 0.5.3
home: https://github.com/spotinst/charts
icon: https://docs.spot.io/_media/images/spot_mark.png
Expand Down
2 changes: 2 additions & 0 deletions charts/bigdata-proxy/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ metadata:
nginx.ingress.kubernetes.io/auth-tls-secret: {{ printf "%s/%s" .Values.ingress.secretNamespace .Values.ingress.secretName }}
# Override proxy timeout to give time for possible cluster scale up
nginx.ingress.kubernetes.io/proxy-read-timeout: {{ .Values.ingress.readTimeout | quote }}
# Override body size to allow file uploads from JupyterLab(workspace)
nginx.ingress.kubernetes.io/proxy-body-size: {{ .Values.ingress.bodySize }}
spec:
ingressClassName: {{ .Values.ingress.ingressClassName }}
rules:
Expand Down
1 change: 1 addition & 0 deletions charts/bigdata-proxy/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ ingress:
host: "" # Overridden at deploy time
secretNamespace: "" # Overridden at deploy time
secretName: "" # Overridden at deploy time
bodySize: "2M"

nameOverride: ""
fullnameOverride: ""
Expand Down

0 comments on commit 79c9fe2

Please sign in to comment.