Skip to content

Commit

Permalink
Readded workspace name config parameter
Browse files Browse the repository at this point in the history
  • Loading branch information
Arnar Páll authored and arnarpall committed Sep 25, 2023
1 parent e01905a commit fb5be7f
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion charts/bigdata-notebook-workspace/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: bigdata-notebook-workspace
description: A Helm chart for the Spot Big Data Notebook Workspace
type: application
version: 0.0.3
version: 0.0.4
appVersion: 4.0.3
home: https://github.com/spotinst/charts
icon: https://docs.spot.io/_media/images/spot_mark.png
Expand Down
2 changes: 1 addition & 1 deletion charts/bigdata-notebook-workspace/templates/helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ bigdata.spot.io/creatorUserId: {{ .Values.creatorUserId | quote }}
Common annotations
*/}}
{{- define "bigdata-notebook-workspace.annotations" -}}
bigdata.spot.io/notebookWorkspaceName: {{ .Release.Name }}
bigdata.spot.io/notebookWorkspaceName: {{ .Values.workspaceName }}
{{- end }}

{{/*
Expand Down
11 changes: 6 additions & 5 deletions charts/bigdata-notebook-workspace/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@

replicaCount: 1
creatorUserId: ""
workspaceName: ""

server:
token: ''
ip: '0.0.0.0'
allowOrigin: '*'

image:
repository: jupyter/base-notebook
Expand All @@ -17,11 +23,6 @@ imagePullSecrets:
nameOverride: ""
fullnameOverride: ""

server:
token: ''
ip: '0.0.0.0'
allowOrigin: '*'

gatewayClient:
enabled: true
url: "http://bigdata-notebook-service.spot-system.svc.cluster.local"
Expand Down

0 comments on commit fb5be7f

Please sign in to comment.