Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use spottoken renewer from the datamechanics jupyter_server fork v2.5.0 #166

Merged
merged 8 commits into from
Nov 21, 2023

Conversation

sigmarkarl
Copy link
Contributor

@sigmarkarl sigmarkarl commented Nov 9, 2023

Use spot token renewer using request from context var

Jira Ticket

BGD-4169

Checklist:

  • I have filled relevant self assessment (NodeJS, Frontend, Backend)
  • I have run ESlint on my changes and fixed all warnings and errors (NodeJS & Frontend Services)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have validated all the requirements in the Jira task were answered
  • I have all neccessary approvals for the design/mini design of this task
  • I have approved the API changes and granular permission patterns (documentation subtask) (For public services only)

@sigmarkarl sigmarkarl requested a review from a team as a code owner November 9, 2023 15:53
@sigmarkarl sigmarkarl closed this Nov 13, 2023
@sigmarkarl sigmarkarl reopened this Nov 13, 2023
Copy link
Contributor

@epignot epignot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks ok to me, but I'm struggling to remember how the version number here correlates to images built in bigdata-infrastructure
@sigmarkarl @arnarpall

@sigmarkarl
Copy link
Contributor Author

it looks ok to me, but I'm struggling to remember how the version number here correlates to images built in bigdata-infrastructure @sigmarkarl @arnarpall

its doesn't correlate. isn't it just the image tag that counts

@arnarpall
Copy link
Contributor

Yeah when I set the appVersion I tied it to the jupyter stacks base notebook tag, but actually forgot to change it when I had to move to 3.6.x of jupyter.

@sigmarkarl sigmarkarl merged commit 75a3988 into main Nov 21, 2023
1 check passed
@sigmarkarl sigmarkarl deleted the BGD-4169-Refresh-workspace-token branch November 21, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants