Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bgd 4393 upgrade workflow notebook image to jupyterlab 4 #171

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Bgd 4393 upgrade workflow notebook image to jupyterlab 4 #171

merged 3 commits into from
Dec 18, 2023

Conversation

sigmarkarl
Copy link
Contributor

@sigmarkarl sigmarkarl commented Dec 17, 2023 •
edited by jira bot
Loading

Add EG_LIST_KERNELS true for jlab4 compatibility

Jira Ticket

BGD-4393

Checklist:

  • I have filled relevant self assessment (NodeJS, Frontend, Backend)
  • I have run ESlint on my changes and fixed all warnings and errors (NodeJS & Frontend Services)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have validated all the requirements in the Jira task were answered
  • I have all neccessary approvals for the design/mini design of this task
  • I have approved the API changes and granular permission patterns (documentation subtask) (For public services only)

@sigmarkarl sigmarkarl requested a review from a team as a code owner December 17, 2023 23:41
@alextarasov-spot
Copy link
Contributor

@sigmarkarl, should we bump the chart version?

bigdata-charts/charts/bigdata-notebook-service/Chart.yaml

Line 5 in bb48bb0

version: 0.2.1

@sigmarkarl sigmarkarl merged commit 0d41296 into main Dec 18, 2023
1 check passed
@sigmarkarl sigmarkarl deleted the BGD-4393-upgrade-workflow-notebook-image-to-jupyterlab-4 branch December 18, 2023 10:48
Z4ck404 pushed a commit that referenced this pull request Jan 8, 2024
@sigmarkarl @Z4ck404
Bgd 4393 upgrade workflow notebook image to jupyterlab 4 (#171)
f6498ad 
* update to jupyterlab 4

* bumped version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextarasov-spot alextarasov-spot alextarasov-spot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sigmarkarl @alextarasov-spot