Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts/bigdata-spark-watcher] added conditional envVars for k8s events collection #222

Conversation

Z4ck404
Copy link
Collaborator

@Z4ck404 Z4ck404 commented Aug 20, 2024

Jira ticket

https://spotinst.atlassian.net/browse/BGD-5418

Description

Phase out using the envVars list in favor of variables for each. More consistent with other charts.
Add new k8s events collection variables.

Demo

Screenshot 2024-09-17 at 15 45 42

Excerpt of successfully installed release manifest configured for the dev environment.

Checklist

  • I have added a Jira ticket link
  • I have filled in the test plan
  • I have executed the tests and filled in the test results
  • I have updated/created relevant documentation

How to test

helm upgrade your installed release (make sure the versions match your installed chart so the operator doesn't try to re-install the previous version)

Test plan and results

Test Description Result Notes
1 Run integration tests

@Z4ck404 Z4ck404 force-pushed the BGD-5418-change-bigdata-spark-watcher-helm-chart-to-set-spotinst-url-the-same-way-as-the-other-charts branch from d2f1f90 to 3337913 Compare August 20, 2024 13:20
@Z4ck404 Z4ck404 force-pushed the BGD-5418-change-bigdata-spark-watcher-helm-chart-to-set-spotinst-url-the-same-way-as-the-other-charts branch 2 times, most recently from 8447f03 to 6a6dec0 Compare September 16, 2024 07:35
@raggivald raggivald self-requested a review September 16, 2024 12:12
@HafdisE HafdisE force-pushed the BGD-5418-change-bigdata-spark-watcher-helm-chart-to-set-spotinst-url-the-same-way-as-the-other-charts branch from d7ff241 to e5fced8 Compare September 17, 2024 14:05
@HafdisE HafdisE force-pushed the BGD-5418-change-bigdata-spark-watcher-helm-chart-to-set-spotinst-url-the-same-way-as-the-other-charts branch 3 times, most recently from a8b3797 to a50c98b Compare September 17, 2024 15:44
@HafdisE HafdisE self-assigned this Sep 17, 2024
@HafdisE HafdisE force-pushed the BGD-5418-change-bigdata-spark-watcher-helm-chart-to-set-spotinst-url-the-same-way-as-the-other-charts branch from a50c98b to 3f86d40 Compare September 17, 2024 16:30
Copy link
Contributor

@raggivald raggivald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with DevCtl

@raggivald raggivald marked this pull request as ready for review September 18, 2024 11:03
@raggivald raggivald requested a review from a team as a code owner September 18, 2024 11:04
@HafdisE HafdisE merged commit 0991b2f into main Sep 18, 2024
1 check passed
@HafdisE HafdisE deleted the BGD-5418-change-bigdata-spark-watcher-helm-chart-to-set-spotinst-url-the-same-way-as-the-other-charts branch September 18, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants