-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts/bigdata-spark-watcher] added conditional envVars for k8s events collection #222
Merged
HafdisE
merged 3 commits into
main
from
BGD-5418-change-bigdata-spark-watcher-helm-chart-to-set-spotinst-url-the-same-way-as-the-other-charts
Sep 18, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abunghez
reviewed
Aug 20, 2024
abunghez
reviewed
Aug 20, 2024
Z4ck404
force-pushed
the
BGD-5418-change-bigdata-spark-watcher-helm-chart-to-set-spotinst-url-the-same-way-as-the-other-charts
branch
from
August 20, 2024 13:20
d2f1f90
to
3337913
Compare
Z4ck404
force-pushed
the
BGD-5418-change-bigdata-spark-watcher-helm-chart-to-set-spotinst-url-the-same-way-as-the-other-charts
branch
2 times, most recently
from
September 16, 2024 07:35
8447f03
to
6a6dec0
Compare
HafdisE
reviewed
Sep 16, 2024
HafdisE
reviewed
Sep 16, 2024
HafdisE
reviewed
Sep 16, 2024
HafdisE
force-pushed
the
BGD-5418-change-bigdata-spark-watcher-helm-chart-to-set-spotinst-url-the-same-way-as-the-other-charts
branch
from
September 17, 2024 14:05
d7ff241
to
e5fced8
Compare
HafdisE
force-pushed
the
BGD-5418-change-bigdata-spark-watcher-helm-chart-to-set-spotinst-url-the-same-way-as-the-other-charts
branch
3 times, most recently
from
September 17, 2024 15:44
a8b3797
to
a50c98b
Compare
HafdisE
force-pushed
the
BGD-5418-change-bigdata-spark-watcher-helm-chart-to-set-spotinst-url-the-same-way-as-the-other-charts
branch
from
September 17, 2024 16:30
a50c98b
to
3f86d40
Compare
raggivald
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with DevCtl
alextarasov-spot
approved these changes
Sep 18, 2024
HafdisE
deleted the
BGD-5418-change-bigdata-spark-watcher-helm-chart-to-set-spotinst-url-the-same-way-as-the-other-charts
branch
September 18, 2024 12:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
https://spotinst.atlassian.net/browse/BGD-5418
Description
Phase out using the envVars list in favor of variables for each. More consistent with other charts.
Add new k8s events collection variables.
Demo
Excerpt of successfully installed release manifest configured for the dev environment.
Checklist
How to test
helm upgrade your installed release (make sure the versions match your installed chart so the operator doesn't try to re-install the previous version)
Test plan and results