[BGD-5896] bns set annotation when shutting down a kernel #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epignot
changed the title
originou
approved these changes
Sep 13, 2024
ImpSy
approved these changes
Sep 13, 2024
bigdata-notebook-service nows sets annotation `kill-requested-at` on SparkApp CR when kernel shutdown (or restart) is requested. a ClusterRole has been added to allow this behaviour in a previous change.
epignot
force-pushed
the
bgd-5896-bns-kill-annotation-on-notebook-shutdown
branch
from
84a40e9 to
8afc99d
Compare
epignot
deleted the
bgd-5896-bns-kill-annotation-on-notebook-shutdown
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
https://spotinst.atlassian.net/browse/BGD-5896
Description
bigdata-notebook-service nows sets annotation
kill-requested-aton SparkApp CR when kernel shutdown (or restart) is requested.a ClusterRole has been added to allow this behaviour in a previous change.
Demo
Please add a recording/screenshot of the feature/bug fix in action
Checklist
How to test
helm upgrade bigdata-notebook-service-bdenv-v30 bigdata-notebook-service -n spot-systemkill-requested-atannotationTest plan and results