Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
https://spotinst.atlassian.net/browse/BGD-4766
Description
Our workspace jupyterlab image is based on the https://quay.io/repository/jupyter/base-notebook image, which has userid 1000 for user jovyan and groupid 100 for group users.
It is recommended to use the start-notebook.py instead of the shell script to launch the jupyterlab process, see.
Demo
Opening a terminal in the workspace notebook no longer runs as root. Also new notebook files are successfully saved on the mounted drive and owned by the jovyan user.
Checklist
How to test
Create a workspace. Edit the deployment and replace the runAsUser: 0 and fsGroup: 0 with 1000 and 100 respectively. Remove the --allow-root and replace start-notebook.sh with start-notebook.py. Launch a notebook from the workspace and run a spark query. Open a terminal in jupyterlab and touch a file to see if the mount is writable.
Test plan and results
Feel free to add screenshots showing test results