disable terminals #243
Closed
disable terminals #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextarasov-spot
requested changes
Nov 12, 2024
|
@sigmarkarl This will be superseded by your PR in the jupyter-server repo right ? |
There was a problem hiding this comment.
image tag and appVersion?
| @@ -10,6 +10,7 @@ server: | |||
| token: '' | |||
| ip: '0.0.0.0' | |||
| allowOrigin: '*' | |||
| terminals_enabled: false | |||
There was a problem hiding this comment.
what will happen if set to true in case the terminal is totally removed in the Jupiter server?
|
we will remove the terminado and jupyter_server_terminals in our custom jupyterlab Dockerfile (bigdata-infrastructure) instead as other components might install terminado |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
https://spotinst.atlassian.net/browse/BGD-5956
Description
Hiding terminal in jupyterlab. This is a cosmetic change and will be further handled in https://spotinst.atlassian.net/browse/BGD-5956
Demo
The launcher now looks like
No terminals launcher visible
Checklist
How to test
See demo screenshot. The terminal launcher should no longer be visible on the jupyterlab launcher page.