Make bigdata-crds manages spark-operator crds #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So we have them in the crds folder for the initial install... and also under templates for installing again on upgrades? Why are the bigdata crds not also following this pattern? |
|
To ease what is "our" tempates and what comes from "external charts", I decided to copy the the crds directory is actually ran after the chart install if the CRD does not already exist |
Signed-off-by: ImpSy <3097030+ImpSy@users.noreply.github.com>
ImpSy
force-pushed
the
BGD-6250_bigdata-crds-manage-spark-operator-crds
branch
from
6cb59ca to
cc14500
Compare
alextarasov-spot
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
https://spotinst.atlassian.net/browse/BGD-6250
Description
https://spotinst.atlassian.net/browse/BGD-6250
Demo
Please add a recording/screenshot of the feature/bug fix in action
Checklist
How to test
Testing was done on this PR -> https://github.com/spotinst/bigdata-operator/pull/358
Test plan and results
Look into https://github.com/spotinst/bigdata-operator/pull/358 to see the helm upgrade diff works