Skip to content

Commit

Permalink
[.github] add CODEOWNERS + ofascommon workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
Z4ck404 committed Nov 15, 2023
1 parent 25caa12 commit 56386f5
Show file tree
Hide file tree
Showing 4 changed files with 50 additions and 29 deletions.
2 changes: 2 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
* @Spotinst/team-bigdata
/.github/ @Spotinst/team-bigdata-devops
37 changes: 21 additions & 16 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,26 +1,31 @@
<!--
Thanks for contributing to JupyterLab!
Please fill out the following items to submit a pull request.
See the contributing guidelines for more information:
https://github.com/jupyterlab/jupyterlab/blob/main/CONTRIBUTING.md
-->
## Jira ticket

## References
https://spotinst.atlassian.net/browse/BGD-XXXX

<!-- Note issue numbers this pull request addresses (should be at least one, see contributing guidelines above). -->
## Checklist
- [ ] I added a Jira ticket link
- [ ] I added a changeset with the `simple-changeset add` command
- [ ] I filled in the test plan
- [ ] I executed the tests and filled in the test results

<!-- Note any other pull requests that address this issue and how this pull request is different. -->
## Why

## Code changes
_A short description of why this change is necessary. If this is a bug fix, include steps to reproduce the issue_

<!-- Describe the code changes and how they address the issue. -->
## What

## User-facing changes
_What has been modified. Expose the key decisions you have made during this PR to facilitate the discussion with your reviewer_

<!-- Describe any visual or user interaction changes and how they address the issue. -->
## How to test

<!-- For visual changes, include before and after screenshots or GIF/mp4/other video demo here. -->
_Step by step instructions to test your feature/fix_

## Backwards-incompatible changes
## Test plan and results

<!-- Describe any backwards-incompatible changes to JupyterLab public APIs. -->
_Feel free to add screenshots showing test results_

| Test | Description | Result | Notes |
|------|-------------------|--------|----------------------------|
| 1 | Test with input A | Pass | Some notes about the test |
| 2 | Test with input B | Pass | Some notes about the test |
| 3 | Test with input C | Pass | Some notes about the test |
27 changes: 27 additions & 0 deletions .github/workflows/common.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: Bigdata Commit Checks

on: [pull_request]

jobs:
ci:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3

# - name: Install devctl
# run: |
# mkdir -p ${{ env.DEVCTL_INSTALL_DIR }}
# curl -H "Authorization: token ${{ env.GITHUB_TOKEN }}" -o- ${{ env.DEVCTL_INSTALL_URL }} | INSTALL_DIR=${{ env.DEVCTL_INSTALL_DIR }} bash
# echo ${{ env.DEVCTL_INSTALL_DIR }} >> $GITHUB_PATH
# shell: bash
# env:
# DEVCTL_INSTALL_DIR: ${{runner.tool_cache}}/devctl
# DEVCTL_INSTALL_URL: https://raw.githubusercontent.com/spotinst/bigdata-devctl/main/install.sh
# GITHUB_TOKEN: ${{secrets.CI_PAT}}

# - name: run validation checks
# run: devctl ci
# env:
# GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
# JIRA_TOKEN: ${{ secrets.JIRA_TOKEN }}
# PR_ID: ${{ github.event.pull_request.number }}
13 changes: 0 additions & 13 deletions .github/workflows/enforce-label.yml

This file was deleted.

0 comments on commit 56386f5

Please sign in to comment.