Merge pull request #11 from spotinst/BGD-4393-fix-websocket-protocol-…

…for-jeg-backward-compat dont use websocket protocol for jeg backward compatibility and fix ke…
spotinst · Jan 11, 2024 · da57ba4 · da57ba4
2 parents a376c5a + 14c5dc6
commit da57ba4
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/packages/running/src/index.tsx b/packages/running/src/index.tsx
@@ -192,13 +192,13 @@ function Item(props: {
             ) : (
               <caretDownIcon.react tag="span" stylesheet="runningItem" />
             ))}
-          {typeof icon === 'string' ? (
-            icon ? (
+          {icon ? (
+            typeof icon === 'string' ? (
               <img src={icon} />
-            ) : undefined
-          ) : (
-            <icon.react tag="span" stylesheet="runningItem" />
-          )}
+            ) : (
+              <icon.react tag="span" stylesheet="runningItem"/>
+            )
+          ) : undefined}
           <span
             className={ITEM_LABEL_CLASS}
             title={title}

diff --git a/packages/services/src/kernel/default.ts b/packages/services/src/kernel/default.ts
@@ -1233,7 +1233,7 @@ export class KernelConnection implements Kernel.IKernelConnection {
   /**
    * Create the kernel websocket connection and add socket status handlers.
    */
-  private _createSocket = (useProtocols = true) => {
+  private _createSocket = (useProtocols = false) => {
     this._errorIfDisposed();
 
     // Make sure the socket is clear

diff --git a/packages/services/src/session/restapi.ts b/packages/services/src/session/restapi.ts
@@ -112,7 +112,7 @@ export async function startSession(
   };
   let data = {"id": "", "execution_state": "waiting"};
   let count = 0
-  while (count++ < 600) {
+  while (count++ < 300) {
     const response = await ServerConnection.makeRequest(url, init, settings);
     if (response.status !== 201) {
       throw await ServerConnection.ResponseError.create(response);