dont use websocket protocol for jeg backward compatibility and fix ke…

…rnel view for non existing icons
spotinst · Jan 10, 2024 · dbbec42 · dbbec42
1 parent ee120c8
commit dbbec42
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/packages/running/src/index.tsx b/packages/running/src/index.tsx
@@ -192,13 +192,13 @@ function Item(props: {
             ) : (
               <caretDownIcon.react tag="span" stylesheet="runningItem" />
             ))}
-          {typeof icon === 'string' ? (
-            icon ? (
+          {icon ? (
+            typeof icon === 'string' ? (
               <img src={icon} />
-            ) : undefined
-          ) : (
-            <icon.react tag="span" stylesheet="runningItem" />
-          )}
+            ) : (
+              <icon.react tag="span" stylesheet="runningItem"/>
+            )
+          ) : undefined}
           <span
             className={ITEM_LABEL_CLASS}
             title={title}

diff --git a/packages/services/src/kernel/default.ts b/packages/services/src/kernel/default.ts
@@ -1233,7 +1233,7 @@ export class KernelConnection implements Kernel.IKernelConnection {
   /**
    * Create the kernel websocket connection and add socket status handlers.
    */
-  private _createSocket = (useProtocols = true) => {
+  private _createSocket = (useProtocols = false) => {
     this._errorIfDisposed();
 
     // Make sure the socket is clear